-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RESTWS-741: Remove 1.8 submodule (Removed 0mod-1.8Controller) #619
base: master
Are you sure you want to change the base?
Conversation
...nmrs/module/webservices/rest/web/v1_0/controller/openmrs1_8/ConceptMapController1_8Test.java
Outdated
Show resolved
Hide resolved
Also, it doesn't look like this removes the whole submodule? |
true i am doing it in phases |
Ah ok! Do you mind if I convert this to a draft then? (I like the idea of doing this in stages!) |
It's fine with |
Let's keep it all in one PR, if that's alright... |
Alright then |
hello @ibacher
|
I've fixed the tests so they work (according to me). |
thank you for this fix
it makes sense with me too let me these changes update my repository and send my last commit |
Description of what I changed
RestTestConstants1_9.java
to include all the constants ofRestTestConstants1_8.java
RestTestConstants1_9.java
Cc. @dkayiwa @ibacher @mks-d
Issue I worked on
see https://openmrs.atlassian.net/browse/RESTWS-741
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amend
I have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amend
I ran
mvn clean package
right before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master